ocket8888 commented on a change in pull request #5252:
URL: https://github.com/apache/trafficcontrol/pull/5252#discussion_r524747944
##########
File path: infrastructure/cdn-in-a-box/optional/vnc/Dockerfile
##########
@@ -14,15 +14,22 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-FROM docker.io/centos:7
+
+ARG CENTOS_VERSION=8
+FROM centos:${CENTOS_VERSION}
+ARG CENTOS_VERSION=8
Review comment:
fair enough, but there are multi-stage builds where I think it's doing
something like:
```dockerfile
ARG CENTOS_VERSION=8
FROM centos:${CENTOS_VERSION}
ARG CENTOS_VERSION=8
# ...
ENV CENTOS_VERSION=${CENTOS_VERSION}
```
could you instead do
```dockerfile
ARG CENTOS_VERSION=8
ENV CENTOS_VERSION=${CENTOS_VERSION}
FROM centos:${CENTOS_VERSION}
```
?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
