rawlinp commented on a change in pull request #5345:
URL: https://github.com/apache/trafficcontrol/pull/5345#discussion_r544684945
##########
File path:
traffic_portal/app/src/common/modules/form/deliveryService/form.deliveryService.DNS.tpl.html
##########
@@ -400,6 +400,22 @@ <h3>Current Value</h3>
</aside>
</div>
</div>
+ <div class="form-group" ng-class="{'has-error':
hasError(cacheConfig.maxRequestHeaderBytes), 'has-feedback':
hasError(cacheConfig.maxRequestHeaderBytes)}">
+ <label class="has-tooltip control-label col-md-2
col-sm-2 col-xs-12" for="maxRequestHeaderBytes">Max Request Header Size<div
class="helptooltip">
Review comment:
this should probably say `Bytes` instead of `Size` here and on the other
forms/tables as well now
##########
File path:
traffic_portal/app/src/common/modules/form/deliveryService/form.deliveryService.DNS.tpl.html
##########
@@ -400,6 +400,22 @@ <h3>Current Value</h3>
</aside>
</div>
</div>
+ <div class="form-group" ng-class="{'has-error':
hasError(cacheConfig.maxRequestHeaderBytes), 'has-feedback':
hasError(cacheConfig.maxRequestHeaderBytes)}">
+ <label class="has-tooltip control-label col-md-2
col-sm-2 col-xs-12" for="maxRequestHeaderBytes">Max Request Header Size<div
class="helptooltip">
+ <div class="helptext">
+ The maximum size of the request headers
for this particular delivery service.
Review comment:
this should probably say "The maximum size (in bytes) of the ..." (as
well as the tooltip on the other form)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
