mitchell852 commented on a change in pull request #5345:
URL: https://github.com/apache/trafficcontrol/pull/5345#discussion_r544764219
##########
File path:
traffic_portal/app/src/common/modules/form/deliveryService/form.deliveryService.HTTP.tpl.html
##########
@@ -400,6 +400,22 @@ <h3>Current Value</h3>
</aside>
</div>
</div>
+ <div class="form-group" ng-class="{'has-error':
hasError(cacheConfig.maxRequestHeaderBytes), 'has-feedback':
hasError(cacheConfig.maxRequestHeaderBytes)}">
+ <label class="has-tooltip control-label col-md-2
col-sm-2 col-xs-12" for="maxRequestHeaderBytes">Max Request Header Bytes<div
class="helptooltip">
+ <div class="helptext">
+ The maximum size (in bytes) of the request
headers for this particular delivery service.
+ </div>
+ </div>
+ </label>
+ <div class="col-md-10 col-sm-10 col-xs-12">
+ <input id="maxRequestHeaderBytes"
name="maxRequestHeaderBytes" type="number" class="form-control"
ng-model="deliveryService.maxRequestHeaderBytes" step="1" min="1"
value="131072">
Review comment:
the value attribute is not needed here. if this is a new ds, the value
of this field will be derived from deliveryService.maxRequestHeaderBytes that
was set in traffic_portal_properties.json. if this is an existing ds, it will
show the ds's value.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
