ocket8888 commented on a change in pull request #4644:
URL: https://github.com/apache/trafficcontrol/pull/4644#discussion_r572330793
##########
File path: lib/go-tc/deliveryservices.go
##########
@@ -226,11 +225,8 @@ type DeliveryServiceNullableV12 struct {
// for all fields to be null.
// TODO move contents to DeliveryServiceNullableV12, fix references, and remove
type DeliveryServiceNullableV11 struct {
- // NOTE: the db: struct tags are used for testing to map to their
equivalent database column (if there is one)
- //
Active *bool `json:"active"
db:"active"`
AnonymousBlockingEnabled *bool
`json:"anonymousBlockingEnabled" db:"anonymous_blocking_enabled"`
- CacheURL *string `json:"cacheurl"
db:"cacheurl"`
Review comment:
It doesn't break anything as far as JSON serialization, but it is a
breaking change to old client call signatures. Changes to old client call
signatures must be non-breaking.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
