ocket8888 commented on a change in pull request #4644:
URL: https://github.com/apache/trafficcontrol/pull/4644#discussion_r574874361
##########
File path: lib/go-tc/deliveryservices.go
##########
@@ -560,6 +767,40 @@ func (ds *DeliveryServiceNullableV30)
validateTypeFields(tx *sql.Tx) error {
return nil
}
+func (ds *DeliveryServiceV40) Validate(tx *sql.Tx) error {
Review comment:
There's a TODO somewhere in the codebase about moving validator methods
internal to TO; I don't think this is the only handler that has this issue. It
is really weird to be requiring a transaction hooked into a TO database in the
supposedly generic library code, but moving it to be internal means re-thinking
the ParseValidator interface and we were thinking of doing that anyway because
of its current inability to return system-level errors. So it might be
something to worry about in a later change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
