zrhoffman commented on a change in pull request #5681:
URL: https://github.com/apache/trafficcontrol/pull/5681#discussion_r602461039



##########
File path: infrastructure/cdn-in-a-box/traffic_ops/Dockerfile
##########
@@ -99,6 +115,8 @@ COPY 
infrastructure/cdn-in-a-box/enroller/server_template.json \
        infrastructure/cdn-in-a-box/traffic_ops/trafficops-init.sh \
        infrastructure/cdn-in-a-box/variables.env \
        /
+COPY infrastructure/cdn-in-a-box/traffic_ops_data /traffic_ops_data
+COPY traffic_router/core/src/test/resources/geo/GeoLite2-City.mmdb.gz 
/opt/traffic_ops/app/public/

Review comment:
       `COPY` instructions are fast and IMO should go at the end of the 
Dockerfile, but I don't have strong feelings about these 2 steps. Reverted 
those lines in 4bae66184d.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to