zrhoffman commented on a change in pull request #5681:
URL: https://github.com/apache/trafficcontrol/pull/5681#discussion_r602435734



##########
File path: traffic_ops/install/bin/_postinstall
##########
@@ -1,5 +1,5 @@
-#!/usr/bin/perl
-
+#!/usr/bin/env bash

Review comment:
       I did use `git mv`
   
   > Did you change this Python code at all?
   
   Not in 83d69c3778, no. Running
   
   ```shell
   git mv _postinstall _postinstall.pl;
   git mv postinstall.py _postinstall;
   ```
   
   yields
   
   ```shell
   Changes to be committed:
     (use "git restore --staged <file>..." to unstage)
           modified:   _postinstall
           new file:   _postinstall.pl
           deleted:    postinstall.py
   ```
   , so I can understanding not wanting both steps to be done in the same 
commit.
   
   Rebased to split that commit into 2 `git mv` commits in ab87a7815e and 
56644eb1d4 (though the overall diff will still be just as big).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to