ocket8888 commented on pull request #5678: URL: https://github.com/apache/trafficcontrol/pull/5678#issuecomment-810453243
> for changetype=delete, requested is not applicable so the requested property is omitted from the json response, correct? can you not omit it and just set its value to null instead. it's weird imo to have a different json structure for different types. > for changetype=create, original is not applicable so the original property is omitted from the json response, correct? can you not omit it and just set its value to null instead. it's weird imo to have a different json structure for different types. The way our API is implemented, those are totally equivalent. You can pass `null` or not pass it at all. Both have the same result. > for a DSR, the xmlId is an interesting piece of information but i have to look in either the requested or original value (depending on changetype) to find it. should we just promote it to a first level property of all DSRs? The problem with that is that the original and requested already have XMLIDs, so at best we're specifying the same information twice. But what do you do if they're not the same? Reject the request? Or treat one as the truth? If you don't treat the original/requested as the truth, then your DSRs are lying to you. So if the XMLID must already exist and be the correct, canonical XMLID on the requested/original, why add it somewhere else, too? For update requests that change the XMLID, to which XMLID does the "top-level" XMLID property refer? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
