ocket8888 commented on pull request #5678:
URL: https://github.com/apache/trafficcontrol/pull/5678#issuecomment-812685640


   > This no longer works:
   
   > `GET /deliveryservice_requests?xmlId=foo&status=submitted`
   
   > It was a pretty handy way to see if a ds had "open" dsrs... and TP 
leverages that query param to "auto-complete" DSRs.
   
   Which part of that no longer works? I can filter by both xmlId and status. I 
tested this just now by:
   
   1. created an "update" DSR for `demo1` in "draft" status
   2. requested `deliveryservice_requests?xmlId=demo1` - returns that DSR
   3. requested `deliveryservice_requests?xmlId=demo2` - returns an empty array
   4. requested `deliveryservice_requests?xmlId=demo1&status=submitted` - 
returns an empty array
   5. update the status to "submitted" (which succeeds but returns a 500, for 
some reason I still have to look into)
   6. requested `deliveryservice_requests?xmlId=demo1` - returns that DSR
   7. requested `deliveryservice_requests?xmlId=demo2` - returns an empty array
   8. requested `deliveryservice_requests?xmlId=demo1&status=submitted` - 
returns that DSR
   
   So it's all working fine from what I can see. Plus I'm pretty confident that 
the API tests exercise at least the XMLID param.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to