ocket8888 commented on a change in pull request #5692:
URL: https://github.com/apache/trafficcontrol/pull/5692#discussion_r604343918
##########
File path: traffic_ops/install/bin/_postinstall
##########
@@ -711,10 +711,10 @@ def unmarshal_config(dct): # type: (dict) -> dict[str,
list[Question]]
return ret
-def setup_maxmind(maxmind_answer, root): # type: (str, str) -> None
+def setup_maxmind(maxmind_answer, root, download_tool = '/usr/bin/curl'): #
type: (str, str, str) -> None
Review comment:
Changing the tool to use `curl` instead of `wget` is technically a
breaking change in the otherwise "drop-in" script. The problem *should* be
solved, as I understand it, by just `except`ing the proper type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
