zrhoffman commented on a change in pull request #5692:
URL: https://github.com/apache/trafficcontrol/pull/5692#discussion_r604366938
##########
File path: traffic_ops/install/bin/_postinstall
##########
@@ -711,10 +711,10 @@ def unmarshal_config(dct): # type: (dict) -> dict[str,
list[Question]]
return ret
-def setup_maxmind(maxmind_answer, root): # type: (str, str) -> None
+def setup_maxmind(maxmind_answer, root, download_tool = '/usr/bin/curl'): #
type: (str, str, str) -> None
Review comment:
IMO this is a silly convo to have because the databases fail to download
now anyway. The whole section might be removed by a PR that addresses #5683, so
which tool to fail with seems like a non-issue.
If #5683 is resolved by changing the URLs for the GeoIP legacy city
databases to a different provider, we will need to change both postinstall
scripts to use `curl` at that time.
Reverted to `wget` for this PR in 3e175361ae.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
