srijeet0406 commented on a change in pull request #5512:
URL: https://github.com/apache/trafficcontrol/pull/5512#discussion_r604496447
##########
File path: traffic_ops/testing/api/v4/cdns_test.go
##########
@@ -49,14 +49,14 @@ func TestCDNs(t *testing.T) {
func UpdateTestCDNsWithHeaders(t *testing.T, header http.Header) {
firstCDN := testData.CDNs[0]
Review comment:
Could you add a `len` check on `testData.CDNs`?
##########
File path: traffic_ops/testing/api/v4/crconfig_test.go
##########
@@ -122,7 +123,9 @@ func UpdateTestCRConfigSnapshot(t *testing.T) {
t.Errorf("GetCRConfig crc.Stats.Path expected:
'"+tmURLExpected+"', actual: %+v", *crc.Stats.TMHost)
}
- paramResp, _, err := TOSession.GetParameterByName(tmURLParamName)
+ params := url.Values{}
+ params.Set("name", tmURLParamName)
+ paramResp, _, err := TOSession.GetParameters(nil, params)
Review comment:
Same comment about the ordering of the method arguments here
##########
File path: traffic_ops/testing/api/v4/cachegroups_test.go
##########
@@ -211,7 +211,7 @@ func GetTestCacheGroups(t *testing.T) {
func GetTestCacheGroupsByName(t *testing.T) {
for _, cg := range testData.CacheGroups {
- resp, _, err := TOSession.GetCacheGroupNullableByName(*cg.Name)
+ resp, _, err := TOSession.GetCacheGroupByName(*cg.Name, nil)
Review comment:
could we add a nil check for cg.Name here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
