srijeet0406 commented on a change in pull request #5512:
URL: https://github.com/apache/trafficcontrol/pull/5512#discussion_r604999185
##########
File path: traffic_ops/v4-client/cdn.go
##########
@@ -35,73 +36,49 @@ func (to *Session) CreateCDN(cdn tc.CDN) (tc.Alerts,
toclientlib.ReqInf, error)
return alerts, reqInf, err
}
-func (to *Session) UpdateCDNByIDWithHdr(id int, cdn tc.CDN, header
http.Header) (tc.Alerts, toclientlib.ReqInf, error) {
+// UpdateCDNByID replaces the identified CDN with the provided CDN.
+func (to *Session) UpdateCDNByID(id int, cdn tc.CDN, header http.Header)
(tc.Alerts, toclientlib.ReqInf, error) {
Review comment:
I think I've made this comment before, but this could just be `UpdateCDN`
##########
File path: traffic_ops/testing/api/v4/cachegroups_test.go
##########
@@ -260,7 +260,7 @@ func topologyCachegroups(top tc.Topology)
map[string]struct{} {
func UpdateTestCacheGroups(t *testing.T) {
firstCG := testData.CacheGroups[0]
- resp, _, err := TOSession.GetCacheGroupNullableByName(*firstCG.Name)
+ resp, _, err := TOSession.GetCacheGroupByName(*firstCG.Name, nil)
Review comment:
Same comment about nil checking
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
