ocket8888 commented on a change in pull request #5701:
URL: https://github.com/apache/trafficcontrol/pull/5701#discussion_r605977460
##########
File path: traffic_ops_db/test/docker/docker-compose.yml
##########
@@ -43,7 +43,7 @@ services:
dockerfile: Dockerfile-db-admin
args:
POSTGRES_VERSION: ${POSTGRES_VERSION:-13.2}
- TRAFFIC_OPS_RPM: traffic_ops.rpm
+ TRAFFIC_OPS_RPM: traffic_ops-*.rpm
Review comment:
I think you could avoid this change by just being explicit about the
destination filename. I'm not really sure that's a big deal, but for CI systems
running this test that for whatever reason have cluttered directories it could
cause them to start installing a bunch of different TO versions at once instead
of the one they want. Again, idk if anyone's doing that - and it seems like not
a great thing to do - but I just thought I'd make the note.
##########
File path: traffic_ops/app/db/admin.go
##########
@@ -176,8 +176,9 @@ func createDB() {
stderr := bytes.Buffer{}
dbExistsCmd.Stderr = &stderr
out, err := dbExistsCmd.Output()
+ // An error is returned if the database could not be found, which is to
be expected. Don't exit on this error.
Review comment:
Why is that to be expected?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
