ocket8888 commented on a change in pull request #5701:
URL: https://github.com/apache/trafficcontrol/pull/5701#discussion_r606070792



##########
File path: traffic_ops/app/db/admin.go
##########
@@ -176,8 +176,9 @@ func createDB() {
        stderr := bytes.Buffer{}
        dbExistsCmd.Stderr = &stderr
        out, err := dbExistsCmd.Output()
+       // An error is returned if the database could not be found, which is to 
be expected. Don't exit on this error.

Review comment:
       No I mean the code should figure out which happened and only fail if 
there was a real failure, and not just because the DB already existed




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to