rawlinp commented on a change in pull request #5922:
URL: https://github.com/apache/trafficcontrol/pull/5922#discussion_r652104969
##########
File path: lib/go-tc/deliveryservices.go
##########
@@ -192,18 +194,416 @@ type DeliveryServiceFieldsV31 struct {
// DeliveryServiceV40 is a Delivery Service as it appears in version 4.0 of the
// Traffic Ops API.
type DeliveryServiceV40 struct {
Review comment:
> Unfortunately, I think mostly duplicated structs are just a fact of
life with a versioned API in Go
I refuse to accept this statement. We need to be aggressively removing old
API versions so that we can collapse the nested structs back into one struct
over time.
Can you make the RFC3339 change without de-embedding the struct? Sure, that
would change it for prior API versions, but that seems like a worthwhile
breakage (if it even does break anything).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
