ocket8888 commented on a change in pull request #5922:
URL: https://github.com/apache/trafficcontrol/pull/5922#discussion_r652115957
##########
File path: lib/go-tc/deliveryservices.go
##########
@@ -192,18 +194,416 @@ type DeliveryServiceFieldsV31 struct {
// DeliveryServiceV40 is a Delivery Service as it appears in version 4.0 of the
// Traffic Ops API.
type DeliveryServiceV40 struct {
Review comment:
> Can you make the RFC3339 change without de-embedding the struct? Sure,
that would change it for prior API versions, but that seems like a worthwhile
breakage (if it even does break anything).
I actually think that might break Traffic Portal and possibly any other
web-based client of the API used heavily for Delivery Service interactions that
may or may not exist. It's possible it wouldn't - one of those is much easier
to test than the other.
>> Unfortunately, I think mostly duplicated structs are just a fact of life
with a versioned API in Go
> I refuse to accept this statement.
Well, in truth, it's more about what we're willing to give up. not
duplicating things is going to mean that you can write code today that won't
compile tomorrow. It's just that I'd rather duplicate things than deal with
that, personally.
> We need to be aggressively removing old API versions
Agree. I think we can deprecate v2 and v3 with ATCv6 as soon as APIv1 is
actually removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
