zrhoffman commented on a change in pull request #6026:
URL: https://github.com/apache/trafficcontrol/pull/6026#discussion_r670026695
##########
File path: infrastructure/ansible/roles/traffic_portal/defaults/main.yml
##########
@@ -208,7 +208,7 @@ tp_default_properties_template:
_comment: Do you want to show a charts button for each server? If so,
where
can the charts be found? xml id will be appended to the provided url.
show: false
- baseUrl: "{{ tp_ts_base_url
}}/dashboard/script/traffic_ops_server.js?which="
+ baseUrl: "{{ tp_ts_base_url }}/dashboard/db/server-stats?var-SERVER="
Review comment:
The Server Grafana dashboard URL should stay the same in this PR
##########
File path: infrastructure/ansible/roles/traffic_portal/defaults/main.yml
##########
@@ -196,7 +196,7 @@ tp_default_properties_template:
customLink:
_comment: Do you want to show a custom link to your own ds
dashboards?
show: false
- baseUrl: "{{ tp_ts_base_url
}}/dashboard/script/traffic_ops_deliveryservice.js?which="
+ baseUrl: "{{ tp_ts_base_url }}/dashboard/db/cdn-overview?var-svc="
Review comment:
The Delivery Service Grafana dashboard URL should stay the same in this
PR
##########
File path: .github/actions/tp-integration-tests/entrypoint.sh
##########
@@ -155,7 +137,6 @@ CHROMIUM_VER=$(docker exec "$CHROMIUM_CONTAINER" chromium
--version | grep -Eo '
GOROOT=/usr/local/go
export PATH="${PATH}:${GOROOT}/bin"
Review comment:
These lines that set `GOROOT` and add it to the `PATH` should also be
removed.
##########
File path: .github/actions/to-integration-tests/entrypoint.sh
##########
@@ -100,7 +77,6 @@ sudo apt-get install -y --no-install-recommends gettext
GOROOT=/usr/local/go
export GOROOT PATH="${PATH}:${GOROOT}/bin"
Review comment:
Another place that the lines that set `GOROOT` and add it to the `PATH`
should be removed
##########
File path: .github/actions/tm-integration-tests/entrypoint.sh
##########
@@ -75,7 +52,6 @@ sudo apt-get install -y --no-install-recommends gettext
GOROOT=/usr/local/go
export GOROOT PATH="${PATH}:${GOROOT}/bin"
Review comment:
These lines that set `GOROOT` and add it to the `PATH` should be removed.
##########
File path: .github/actions/pr-to-update-go/update_golang_org_x.sh
##########
@@ -19,31 +19,10 @@
set -o errexit -o nounset
trap 'echo "Error on line ${LINENO} of ${0}"; exit 1' ERR
-# download_go downloads and installs the GO version specified in GO_VERSION
-download_go() {
- . build/functions.sh
- if verify_and_set_go_version; then
- return
- fi
- go_version="$(cat "${GITHUB_WORKSPACE}/GO_VERSION")"
- wget -O go.tar.gz
"https://dl.google.com/go/go${go_version}.linux-amd64.tar.gz"; --no-verbose
- echo "Extracting Go ${go_version}..."
- <<-'SUDO_COMMANDS' sudo sh
- set -o errexit
- go_dir="$(command -v go | xargs realpath | xargs dirname | xargs dirname)"
- mv "$go_dir" "${go_dir}.unused"
- tar -C /usr/local -xzf go.tar.gz
- SUDO_COMMANDS
- rm go.tar.gz
- go version
-}
-
GOROOT=/usr/local/go
export PATH="${PATH}:${GOROOT}/bin"
Review comment:
The lines that set `GOROOT` and add it to the `PATH` should be removed
here, too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
