zrhoffman commented on a change in pull request #6026:
URL: https://github.com/apache/trafficcontrol/pull/6026#discussion_r673267522
##########
File path: .github/workflows/tm.integration.tests.yml
##########
@@ -52,3 +52,10 @@ jobs:
uses: ./.github/actions/tm-integration-tests
env:
GOPATH: /github/workspace
+ - name: go-version
+ run: echo "::set-output name=value::$(cat GO_VERSION)"
+ - name: Install Go
+ uses: actions/setup-go@v2
+ with:
+ go-version: ${{ steps.go-version.outputs.value }}
+
Review comment:
This extra newline at the end of `tm.integration.tests.yml` can be
removed.
##########
File path: .github/workflows/tm.integration.tests.yml
##########
@@ -52,3 +52,10 @@ jobs:
uses: ./.github/actions/tm-integration-tests
env:
GOPATH: /github/workspace
+ - name: go-version
Review comment:
`go-version` needs to be the step `id`, not the step `name` in order for
the next step to be able to reference this step as `steps.go-version`.
##########
File path: .github/workflows/tm.integration.tests.yml
##########
@@ -52,3 +52,10 @@ jobs:
uses: ./.github/actions/tm-integration-tests
env:
GOPATH: /github/workspace
+ - name: go-version
+ run: echo "::set-output name=value::$(cat GO_VERSION)"
+ - name: Install Go
+ uses: actions/setup-go@v2
+ with:
+ go-version: ${{ steps.go-version.outputs.value }}
Review comment:
Setting up Go needs to come before the *Run integration tests* step.
##########
File path: go.mod
##########
@@ -64,7 +64,6 @@ require (
golang.org/x/crypto v0.0.0-20210506145944-38f3c27a63bf
golang.org/x/net v0.0.0-20210505214959-0714010a04ed
golang.org/x/sys v0.0.0-20210503173754-0981d6026fa6
- golang.org/x/text v0.3.6 // indirect
Review comment:
Did you mean to commit this change to `go.mod`?
##########
File path: .github/workflows/tm.integration.tests.yml
##########
@@ -52,3 +52,10 @@ jobs:
uses: ./.github/actions/tm-integration-tests
env:
GOPATH: /github/workspace
+ - name: go-version
Review comment:
This can be a human-readable name instead of *go-version*.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
