dneuman64 commented on pull request #6017: URL: https://github.com/apache/trafficcontrol/pull/6017#issuecomment-880859905
I think a major concern is that Traffic Portal definitely does do a put and get back to back within a second. I understand that without adding a CCH to the HTTP handler, that we could be getting stale data back and that could definitely cause confusion. So, @rawlinp and @rob05c how about this: First of all, we keep the agreed upon idea of making this disabled by default. This way a smaller CDN operator doesn't have to worry about this if they don't want to. Next, we make the cache/RWW only apply starting in API 4.x and higher. This makes it so that API 3.x and older is not "broken" and when clients using the API move to 4.x they can update their client to use CCH if they choose. This also keeps us sticking to the HTTP spec and not adding more code to handle a non-standard thing. Finally, we should probably update the Traffic Portal code that uses API 4.x to also send CCH headers. I am not sure how much work that is or where TP is using 4.x, but it is something we should probably do. This can be in the same PR or a different one, it doesn't really matter to me. Ultimately this is functionality that we need and that we need to get into the 6.0 release. Hopefully we can come to an agreement (even if it is not ideal) and get this across the finish line. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
