rawlinp commented on pull request #6017:
URL: https://github.com/apache/trafficcontrol/pull/6017#issuecomment-880932816
That sounds agreeable to me.
> Finally, we should probably update the Traffic Portal code that uses API
4.x to also send CCH headers
I checked Traffic Portal, and it looks like it's actually already setting
these `cache-control` headers for every request:
```
app.js
534:trafficPortal.config(function ($httpProvider) {
535: $httpProvider.interceptors.push('authInterceptor');
538: if (!$httpProvider.defaults.headers.get) {
539: $httpProvider.defaults.headers.get = {};
541: $httpProvider.defaults.headers.get['Cache-Control'] = 'no-cache,
no-store, must-revalidate';
542: $httpProvider.defaults.headers.get['Pragma'] = 'no-cache';
543: $httpProvider.defaults.headers.get['Expires'] = 0;
```
I believe those were added because Chrome started caching responses after
the `last-modified` response header was added during the TO IMS project.
We should also be sure that this has an entry in the changelog that states
that TO API v4 responses will be cached by TO (if enabled), and that clients
should set `cache-control` headers if they need to bypass it. Also, big
breaking changes like this probably deserve a mailing list announcement as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
