ocket8888 commented on a change in pull request #6009:
URL: https://github.com/apache/trafficcontrol/pull/6009#discussion_r670719264
##########
File path:
traffic_portal/app/src/common/modules/table/roleUsers/table.roleUsers.tpl.html
##########
@@ -64,6 +65,7 @@
<td data-search="^{{::u.tenant}}$">{{::u.tenant}}</td>
<td data-search="^{{::u.rolename}}$">{{::u.rolename}}</td>
<td
data-search="^{{::u.registrationSent}}$">{{::u.registrationSent}}</td>
+ <td
data-search="^{{::getRelativeTime(u.lastAuthenticated)}}$">{{::getRelativeTime(u.lastAuthenticated)}}</td>
Review comment:
`getRelativeTime` doesn't handle null values, so if a user has never
logged in the table will display "Invalid date" as their last authentication
time. It should say "never" or similar.
This will happen whenever a new user is created or registered until they
then log in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
