rimashah25 commented on pull request #6009:
URL: https://github.com/apache/trafficcontrol/pull/6009#issuecomment-881759926


   > Everything seems to work fine with the exception of my one comment about 
handling an edge case, but I did have one last concern: since we're saving the 
authentication time to the database, login is now a modifying operation on a 
user. Tangibly this just means that every time you log in it updates 
`lastUpdated`:
   > 
   > ```
   > ocket8888 $ toget -kpa 4.0 'users?username=admin' | jq 
'.response[0].lastUpdated'
   > "2021-07-15 18:45:27+00"
   > ocket8888 $ toget -kpa 4.0 'users?username=admin' | jq 
'.response[0].lastUpdated'
   > "2021-07-15 18:45:30+00"
   > ```
   > 
   > (`toget` re-authenticates on every call)
   > 
   > I don't necessarily think this is a problem, I just want to make sure we 
knew this was going to happen and that it was determined to not be a problem 
and this is intentional. I can't think of any kind of big caching implications 
or anything.
   
   Yes, that is an expected behaviour where the field `lastUpdated` will be 
updated for two reasons: 1. when user logins and 2.  if a user makes any 
changes to the user profile.  
   The field `lastAuthenticated` will be updated only when a user logs in.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to