ocket8888 commented on a change in pull request #6232:
URL: https://github.com/apache/trafficcontrol/pull/6232#discussion_r718902656
##########
File path: traffic_portal/test/integration/specs/Profiles.spec.ts
##########
@@ -94,12 +94,9 @@ profiles.tests.forEach(async profilesData => {
});
});
});
-
describe('Clean up API for Profiles', () => {
- afterAll(async function () {
- it('Cleanup', async () => {
- await api.UseAPI(profiles.cleanup);
- });
- })
+ it('Cleanup', async () => {
+ await api.UseAPI(profiles.cleanup);
+ });
Review comment:
Was this file supposed to be changed?
##########
File path: traffic_portal/test/integration/specs/Types.spec.ts
##########
@@ -36,39 +36,50 @@ describe('Setup API for Types Test', () => {
types.tests.forEach(async typesData => {
typesData.logins.forEach(login => {
describe(`Traffic Portal - Types - ${login.description}`, () => {
+ afterEach(async function () {
+ await typesPage.OpenTypesPage();
+ });
+ afterAll(async function () {
+ expect(await topNavigation.Logout()).toBe(true);
+ })
it('can login', async () => {
browser.get(browser.params.baseUrl);
await loginPage.Login(login);
- expect(await loginPage.CheckUserName(login)).toBeTruthy();
- });
- it('can open types page', async () => {
+ expect(await loginPage.CheckUserName(login)).toBe(true);
await typesPage.OpenConfigureMenu();
- await typesPage.OpenTypesPage();
});
-
+ typesData.toggle.forEach(toggle => {
+ it(toggle.description, async () => {
+ if(toggle.description.includes('hide')){
+ expect(await
typesPage.ToggleTableColumn(toggle.Name)).toBe(true);
+ }else{
+ expect(await
typesPage.ToggleTableColumn(toggle.Name)).toBe(true);
+ }
Review comment:
This looks like it's doing the same thing regardless of which path is
taken - is that check necessary?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
