ocket8888 commented on a change in pull request #6232:
URL: https://github.com/apache/trafficcontrol/pull/6232#discussion_r719586793
##########
File path: traffic_portal/test/integration/specs/Profiles.spec.ts
##########
@@ -94,12 +94,9 @@ profiles.tests.forEach(async profilesData => {
});
});
});
-
describe('Clean up API for Profiles', () => {
- afterAll(async function () {
- it('Cleanup', async () => {
- await api.UseAPI(profiles.cleanup);
- });
- })
+ it('Cleanup', async () => {
+ await api.UseAPI(profiles.cleanup);
+ });
Review comment:
> After couple test and research. The afterAll can only be use one in a
spec file regardless how many describe you put it in.
Where did you hear that? [The Jasmine `afterAll`
docs](https://jasmine.github.io/api/3.9/global.html#afterAll) say:
> Run some shared teardown once after all of the specs in the `describe` are
run.
So you should be able to have one per `describe`. After all, hasn't this
been working for a while now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
