lestrrat opened a new pull request #6380: URL: https://github.com/apache/trafficcontrol/pull/6380
Hi, I am the author of github.com/lestrrat-go/jwx. During a routine search I noticed that this project uses a rather antiquated version of that library. After reviewing I realized that you probably have not upgraded the module because `jwt.Set` has been turned into an interface during the v0.9.x to v1.x transition. You probably needed to allow private parameters in the `jwk.Set` deserialization. I have tentatively implemented it in the main branch for github.com/lestrrat-go/jwx, and applied the changes I _think_ are required to make things work on your end. Currently the PR uses an unreleased version of github.com/lestrrat-go/jwx. If these changes actually work for you, I should probably release 1.2.12 first, and then have this PR merged. Please note that I have only verified that `make unit` mostly works -- I did not run the `TestRemapConfig` and its related tests, and did not verify `trafficcontrol` running in any other form. Also, I reviewed your PR template, but didn't think this particular PR really fits into your regular type of PR. I especially have no clue how `trafficcontrol` works, and just changed the minimal code so that it works with the new version of jwx. And to that extent, I made the judgement call to set aside your templates, as I do not believe I can really respond to your PR template. I feel bad for ignoring the rules, but I hope you understand my position. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
