zrhoffman commented on a change in pull request #6380:
URL: https://github.com/apache/trafficcontrol/pull/6380#discussion_r758857475



##########
File path: traffic_ops/traffic_ops_golang/urisigning/urisigning.go
##########
@@ -62,7 +63,7 @@ func GetURIsignkeysHandler(w http.ResponseWriter, r 
*http.Request) {
                return
        }
        if len(ro) == 0 {
-               ro, err = json.Marshal(tc.URISignerKeyset{})
+               ro, err = json.Marshal(jwk.NewSet())

Review comment:
       For backwards compatibility, `urisigning.GetURIsignkeysHandler()` should 
return
   ```json
   {
       "renewal_kid": null,
       "keys": null
   }
   ```
   
   when there are no URI signing keys (see apache/trafficcontrol#5884).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to