rob05c commented on a change in pull request #6529:
URL: https://github.com/apache/trafficcontrol/pull/6529#discussion_r796029725
##########
File path: lib/go-atscfg/remapdotconfig.go
##########
@@ -401,14 +470,16 @@ func buildEdgeRemapLine(
remapConfigParams []tc.Parameter,
cacheGroups map[tc.CacheGroupName]tc.CacheGroupNullable,
nameTopologies map[TopologyName]tc.Topology,
-) (string, []string, error) {
+) (RemapLines, []string, error) {
warnings := []string{}
+ var remapLines RemapLines
Review comment:
Nitpick: the cache config code generally tries to use the idiom of
always declaring variables with `:=`.
There's no reason for Go to have multiple ways to declare variables, and IMO
it's a slight readability improvement to always use `:=`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
