rob05c commented on a change in pull request #6529:
URL: https://github.com/apache/trafficcontrol/pull/6529#discussion_r796033355
##########
File path: lib/go-atscfg/remapdotconfig.go
##########
@@ -289,16 +313,39 @@ func getServerConfigRemapDotConfigForMid(
if midRemap != "" {
midRemaps[remapFrom] = *ds.OrgServerFQDN + midRemap
}
+
+ // Any raw pre or post pend
+ dsPreRemaps, dsPostRemaps :=
lastPrePostRemapLinesFor(dsConfigParamsMap, *ds.XMLID)
+
+ // Add to pre/post remap lines if this is last tier
+ if 0 < len(dsPreRemaps) || 0 < len(dsPostRemaps) {
+ isLastCache, err := serverIsLastCacheForDS(server, &ds,
nameTopologies, cacheGroups)
+ if err != nil {
+ warnings = append(warnings, "ds '"+*ds.XMLID+"'
errors determining last tier "+err.Error())
Review comment:
If this fails, it just keeps going and generates the line without the
pre and post directives? I think the warning should probably say that, it's not
clear from the warning that that happened.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
