rawlinp commented on a change in pull request #6527:
URL: https://github.com/apache/trafficcontrol/pull/6527#discussion_r804112914
##########
File path: traffic_monitor/config/config.go
##########
@@ -237,6 +235,9 @@ func (c *Config) UnmarshalJSON(data []byte) error {
if aux.TrafficOpsMaxRetryIntervalMs != nil {
c.TrafficOpsMaxRetryInterval =
time.Duration(*aux.TrafficOpsMaxRetryIntervalMs) * time.Millisecond
}
+ if c.StatPolling && c.DistributedPolling {
+ return errors.New("invalid configuration: stat_polling cannot
be enabled if distributed_polling is also enabled")
Review comment:
Not really, that is a perfectly valid state. TMs don't have to be
distributed in order to disable health polling. If, for instance, someone's
legacy TMs were overloaded, they could disable stat polling without going
distributed in order to reduce load.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
