ocket8888 commented on a change in pull request #6532:
URL: https://github.com/apache/trafficcontrol/pull/6532#discussion_r813354774
##########
File path: .github/actions/pr-to-update-go/pr_to_update_go/go_pr_maker.py
##########
@@ -24,81 +24,190 @@
import re
import subprocess
import sys
-from typing import Optional
+from typing import Optional, TypedDict, Any, Final
Review comment:
No, those are to support updating the `.env` file and also addresses
some `Pylint`/`Pyright` errors I was seeing. I still haven't managed to get the
`kwargs` stuff in the block that actually updates files to be happy with its
typing for Pyright, but I spent way too long already trying to figure that out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
