ocket8888 commented on a change in pull request #6532: URL: https://github.com/apache/trafficcontrol/pull/6532#discussion_r813407468
########## File path: dev/traffic_router/conf/startup.properties ########## @@ -0,0 +1,30 @@ +# +# Licensed under the Apache License, Version 2.0 (the "License"); +# you may not use this file except in compliance with the License. +# You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +# Any environment variables you define here will become part of the startup +# environment for the 'traffic_router' service. It is a good place to set +# command line arguments for the Java command line or any environment specific +# setting you want available to the traffic_router process. +# This file is not replaced by the update process when a new version of traffic +# router is installed. +CATALINA_OPTS="\ Review comment: > This is not resolved I thought it was - the file is gone, and Traffic Router seems to not need any of these settings to work so I don't think we need them anywhere else. The only one of these I actually understand is the library path, and I'm like 95% sure that only matters for Tomcat Native, which isn't being used in the dev environment. Not sure what the others mean but they can't be terribly important if it's working without them, can they? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
