ocket8888 commented on code in PR #6544:
URL: https://github.com/apache/trafficcontrol/pull/6544#discussion_r846413972


##########
traffic_ops/testing/api/v4/tc-fixtures.json:
##########
@@ -2817,8 +2817,8 @@
                             "serviceAddress": false
                         },
                         {
-                            "address": "127.0.0.13/30",
-                            "gateway": "127.0.0.1",
+                            "address": "128.0.0.13/30",
+                            "gateway": "128.0.0.1",

Review Comment:
   That doesn't seem related - especially since those tests failed at all three 
API versions, but you only changed the v4 fixtures - which are run last, as 
well. The first problem I see in the APIv2 test logs is
   ```
       servers_test.go:39: Response:  edge2-cdn1-cg3   {[{server was created. 
success}]}
       servers_test.go:56: Failed to get at least one server by hostname 
'edge2-cdn1-cg3'
   ```
   and then it fails to delete that server, and fails to delete things 
associated with it, and then fails to create those things because they already 
exist. Each other API version failure looks similar, but it's hard to say. If a 
server with a hostname is created and then cannot later be filtered for in a 
GET, it seems like it caught a real bug in TO, and I can't understand why 
changing an IP address in a file not used by that test would fix that.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to