ocket8888 commented on code in PR #6544:
URL: https://github.com/apache/trafficcontrol/pull/6544#discussion_r846468257
##########
traffic_ops/testing/api/v4/tc-fixtures.json:
##########
@@ -2817,8 +2817,8 @@
"serviceAddress": false
},
{
- "address": "127.0.0.13/30",
- "gateway": "127.0.0.1",
+ "address": "128.0.0.13/30",
+ "gateway": "128.0.0.1",
Review Comment:
I just verified that those IP changes are the only things necessary to make
the tests pass or fail. So you're right, but here's the thing. The error it's
hitting (in v4 anyway, idk what's going in v2 and v2 isn't broken at the tip of
your branch so I'm just gonna ignore that for now) is:
```
--- FAIL: TestCacheGroups (5.36s)
servers_test.go:567: could not create server 'atlanta-org-1': error
requesting Traffic Ops: path 'https://localhost:6443/api/4.0/servers' gave HTTP
error 400 Bad Request - error-level alerts: there exists a server with id 6315
on the same profile that has the same service address 127.0.0.17/30 - alerts:
[{Text:there exists a server with id 6315 on the same profile that has the same
service address 127.0.0.17/30 Level:error}]
```
That's with the `tc-fixtures.json` from master just updated to use
`profileNames` instead of `profile` on servers. There are 2 servers in the
fixtures that use `127.0.0.17` - `atlanta-org-1` and `atlanta-mid-17` and both
use it as their service address, that's true. But, `atlanta-mid-17` has
`"profileNames": ["MID2"]` and `atlanta-org-1` has `"profileNames": ["EDGE1"]`.
So changing these IP addresses makes the tests pass, but only because it's
hiding a bug. Two servers aren't allowed to share the same IP service address
ever, because TO always thinks that they share a Profile. I believe I have a
comment somewhere else asking about how we wanna go about handling that
situation, but in any case what is happening right now is too restrictive; two
different servers need to be able to share a service IP address as long as
other conditions aren't met.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
