shamrickus commented on code in PR #7000:
URL: https://github.com/apache/trafficcontrol/pull/7000#discussion_r940284613


##########
experimental/traffic-portal/src/app/shared/tree-select/tree-select.component.html:
##########
@@ -14,15 +14,15 @@
 <div class="tree-select-root" role="combobox">
        <mat-form-field>
                <mat-label>{{label}}</mat-label>
-               <input type="text" id="{{handle}}-tree-select" 
name="{{handle}}-tree-select" matInput required readonly 
(click)="toggle($event)" [(ngModel)]="selected.name" [disabled]="disabled"/>
+               <input type="search" id="{{handle}}-tree-select" 
name="{{handle}}-tree-select" matInput required readonly 
(click)="toggle($event)" [(ngModel)]="selected.name" [disabled]="disabled"/>
        </mat-form-field>
        <div class="tree-select-content" *ngIf="shown">
                <mat-form-field appearance="fill" 
(click)="$event.stopPropagation()">
                        <mat-label>Filter</mat-label>
                        <input type="text" (input)="filterChanged($event)" 
id="filter-{{handle}}" name="filter-{{handle}}" matInput/>
                </mat-form-field>
                <mat-tree [dataSource]="treeData" [treeControl]="treeControl">
-                       <mat-tree-node *matTreeNodeDef="let node" 
matTreeNodeToggle [class.hidden-node]="!isVisible(node)">
+                       <mat-tree-node *matTreeNodeDef="let node" 
matTreeNodeToggle [style.display]="!isVisible(node) ? 'none' : 'block'">

Review Comment:
   That does end up breaking things.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to