ocket8888 commented on code in PR #7000: URL: https://github.com/apache/trafficcontrol/pull/7000#discussion_r940526544
########## experimental/traffic-portal/src/app/shared/tree-select/tree-select.component.html: ########## @@ -0,0 +1,47 @@ +<!-- +Licensed under the Apache License, Version 2.0 (the "License"); +you may not use this file except in compliance with the License. +You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, software +distributed under the License is distributed on an "AS IS" BASIS, +WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +See the License for the specific language governing permissions and +limitations under the License. +--> +<div class="tree-select-root" role="combobox"> + <mat-form-field> + <mat-label>{{label}}</mat-label> + <input type="text" id="{{handle}}-tree-select" name="{{handle}}-tree-select" matInput required readonly (click)="toggle($event)" [(ngModel)]="selected.name" [disabled]="disabled"/> Review Comment: Because this input is disabled, it has `cursor: not-allowed`, because of the global stylesheet rule. But actually, clicking on it is a valid action that does something useful, so it should probably have e.g. `cursor: pointer` ########## experimental/traffic-portal/src/app/core/users/tenants/tenants.component.ts: ########## @@ -122,6 +114,15 @@ export class TenantsComponent implements OnInit, OnDestroy { multiRow: true, name: "Disable" }); + this.contextMenuItems.push({ + href: (t: Tenant): string => `core/tenants/${t.id}`, + name: "View Details" + }); + this.contextMenuItems.push({ + href: (t: Tenant): string => `core/tenants/${t.id}`, + name: "Open in New Tab", + newTab: true + }); Review Comment: I don't know why, but I can't get a context menu to appear on the Tenant's table anymore. This is the only thing that would've changed in that regard, so I feel like it has to be the problem, but I can't really see why that would be, to be honest. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
