ocket8888 commented on code in PR #7099:
URL: https://github.com/apache/trafficcontrol/pull/7099#discussion_r1021893838
##########
docs/source/api/v5/deliveryservice_requests.rst:
##########
@@ -663,59 +504,315 @@ The response is a full representation of the edited
:term:`Delivery Service Requ
"protocol": 2,
"qstringIgnore": 0,
"rangeRequestHandling": 0,
+ "rangeSliceBlockSize": null,
"regexRemap": null,
"regional": false,
"regionalGeoBlocking": false,
"remapText": null,
"routingName": "video",
+ "serviceCategory": null,
"signed": false,
- "sslKeyVersion": 1,
- "tenantId": 1,
- "type": "HTTP",
- "typeId": 1,
- "xmlId": "demo1",
- "exampleURLs": [
- "http://video.demo1.mycdn.ciab.test";,
- "https://video.demo1.mycdn.ciab.test";
- ],
- "deepCachingType": "NEVER",
- "fqPacingRate": null,
"signingAlgorithm": null,
+ "sslKeyVersion": 1,
"tenant": "root",
+ "tenantId": 1,
+ "tlsVersions": null,
+ "topology": "demo1-top",
"trResponseHeaders": null,
"trRequestHeaders": null,
- "consistentHashRegex": null,
+ "type": "HTTP",
+ "typeId": 1,
+ "xmlId": "demo1"
+ },
+ "requested": {
+ "active": "INACTIVE",
+ "anonymousBlockingEnabled": false,
+ "ccrDnsTtl": null,
+ "cdnId": 2,
+ "cdnName": "CDN-in-a-Box",
+ "checkPath": null,
"consistentHashQueryParams": [
"abc",
"pdq",
"xxx",
"zyx"
],
- "maxOriginConnections": 0,
+ "consistentHashRegex": null,
+ "deepCachingType": "NEVER",
+ "displayName": "Demo 1",
+ "dnsBypassCname": null,
+ "dnsBypassIp": null,
+ "dnsBypassIp6": null,
+ "dnsBypassTtl": null,
+ "dscp": 0,
"ecsEnabled": false,
- "rangeSliceBlockSize": null,
- "topology": "demo1-top",
+ "edgeHeaderRewrite": null,
+ "exampleURLs": [
+ "http://video.demo1.mycdn.ciab.test";,
+ "https://video.demo1.mycdn.ciab.test";
+ ],
"firstHeaderRewrite": null,
+ "fqPacingRate": null,
+ "geoLimit": 0,
+ "geoLimitCountries": null,
+ "geoLimitRedirectURL": null,
+ "geoProvider": 0,
+ "globalMaxMbps": null,
+ "globalMaxTps": null,
+ "httpBypassFqdn": null,
+ "id": 1,
+ "infoUrl": null,
+ "initialDispersion": 1,
"innerHeaderRewrite": null,
+ "ipv6RoutingEnabled": true,
"lastHeaderRewrite": null,
+ "lastUpdated": "2020-02-13T16:43:54Z",
Review Comment:
RFC3339 allows sub-second precision to be either included or omitted. In Go,
you can choose between the two by using `time.RFC3339` vs `time.RFC3339Nano`.
However, if the sub-second parts would all be zero (e.g. `time.Time{}`; the
"zero-value" of a time.Time) they will be left off even if you use
`time.RFC3339Nano`. So all that to say: Our API can and will produce timestamps
in RFC3339 format that include or exclude the sub-second parts, and any
consumer of the API needs to be prepared to handle both scenarios.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
