rimashah25 commented on code in PR #7099: URL: https://github.com/apache/trafficcontrol/pull/7099#discussion_r1021926483
########## traffic_ops/app/db/migrations/2022110908494015_ds_active_flag.down.sql: ########## @@ -0,0 +1,74 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with this + * work for additional information regarding copyright ownership. The ASF + * licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations under + * the License. + */ + +ALTER TABLE public.deliveryservice +ADD COLUMN active_flag boolean DEFAULT FALSE NOT NULL; + +UPDATE public.deliveryservice +SET active_flag = FALSE +WHERE active = 'PRIMED' OR active = 'INACTIVE'; + +UPDATE public.deliveryservice +SET active_flag = TRUE +WHERE active = 'ACTIVE'; + +ALTER TABLE public.deliveryservice DROP COLUMN active; +ALTER TABLE public.deliveryservice RENAME COLUMN active_flag TO active; +DROP TYPE public.ds_active_state; + +UPDATE public.deliveryservice_request +SET + deliveryservice = jsonb_set(deliveryservice, '{active}', 'true') +WHERE + deliveryservice IS NOT NULL + AND + deliveryservice ? 'active' + AND + deliveryservice ->> 'active' = 'ACTIVE'; +UPDATE public.deliveryservice_request Review Comment: Ok, for me it definitely removes readability but i'll leave the decision on you if you want to change it or not. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
