ocket8888 commented on code in PR #7099:
URL: https://github.com/apache/trafficcontrol/pull/7099#discussion_r1025615404
##########
traffic_ops/testing/api/utils/utils.go:
##########
@@ -119,7 +130,7 @@ type V3TestData struct {
// V3TestDataT represents the data needed for testing the v3 api endpoints.
type V3TestDataT[B any] struct {
- EndpointId func() int
+ EndpointID func() int
Review Comment:
Removing is very simple (if somewhat annoying because I already did that and
then un-did it) but I don't think that work fully captures what Rima means by
"it would be more work at this point to remove it". It doesn't belong in the
PR, that's true, but it's already been reviewed as a part of this PR. It was a
_simple_ change, but not a _small_ one. So to pull that out into a separate PR
is duplicating work already spent on reviewing those changes here, which isn't
insignificant. Having already volunteered yourself for the task, it's clear
you're prepared to take on that tedium, but consider that the time it took Rima
to review it already will have been wasted, which is why she asked me to put it
back in after I took it out.
At this point I've put it in, taken it out, and put it back in again. I
truly do not care if it goes in this PR, but if I change it again I want to be
assured it'll be the last time. Perhaps get a third reviewer to break the tie.
Or don't if you can come to a consensus without that. But I just need to know
what I have to do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
