ocket8888 commented on code in PR #7099:
URL: https://github.com/apache/trafficcontrol/pull/7099#discussion_r1025640302
##########
traffic_ops/testing/api/utils/utils.go:
##########
@@ -119,7 +130,7 @@ type V3TestData struct {
// V3TestDataT represents the data needed for testing the v3 api endpoints.
type V3TestDataT[B any] struct {
- EndpointId func() int
+ EndpointID func() int
Review Comment:
> ...it looks like https://github.com/apache/trafficcontrol/pull/7099 is
missing test coverage for the "PRIMED" DeliveryServiceActiveState.
I see two Delivery Services in the fixtures data that use that active state,
so it seems to be covered to me. It's also worth noting that all Delivery
Services with `active: false` in APIv3 and APIv4 tests are implicitly using
"PRIMED"; technically the new state is "INACTIVE", not "PRIMED".
> ... missing coverage for an invalid DeliveryServiceActiveState being
POSTed or PUT.
That's true. Ideally it should have both.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
