ocket8888 commented on code in PR #7400: URL: https://github.com/apache/trafficcontrol/pull/7400#discussion_r1142641515
########## traffic_ops/testing/api_contract/v4/test_cdns.py: ########## @@ -0,0 +1,68 @@ +"""Api Contract Test Case for cdns endpoint""" +import json +import logging +import pytest + +# Create and configure logger +logger = logging.getLogger() + + [email protected](name="get_cdn_data") +def get_cdn_prereq_data(): + """PyTest Fixture to store prereq data for cdns endpoint""" + # Response keys for cdns endpoint + with open('prerequisite_data.json', encoding="utf-8", mode='r') as prereq_file: + data = json.load(prereq_file) + cdn_data = data["cdns"] + return cdn_data + + +def test_get_cdn(to_session, get_cdn_data, cdn_prereq): Review Comment: Every function returns something, but if your function has no explicit `return` statement the returned value is simply `None`, which would be the return type of this function. > And argument types were added before. I see types mentioned in the docstrings, but more importantly they're missing on the actual arguments -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
