gokulakrishnansvm commented on code in PR #7400: URL: https://github.com/apache/trafficcontrol/pull/7400#discussion_r1144016601
########## traffic_ops/testing/api_contract/v4/test_cdns.py: ########## @@ -0,0 +1,72 @@ +# +# Licensed under the Apache License, Version 2.0 (the "License"); +# you may not use this file except in compliance with the License. +# You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +"""Api Contract Test Case for cdns endpoint.""" +import json +import logging +import pytest + +# Create and configure logger +logger = logging.getLogger() + + [email protected](name="get_cdn_data") +def get_cdn_prereq_data() -> dict: + """PyTest Fixture to store prereq data for cdns endpoint. + :returns cdn_data: Returns prerequisite data for cdns endpoint + """ + # Response keys for cdns endpoint + with open("prerequisite_data.json", encoding="utf-8", mode="r") as prereq_file: + data = json.load(prereq_file) + cdn_data = data["cdns"] + return cdn_data + + +def test_get_cdn(to_session: object, get_cdn_data: dict, cdn_prereq: list) -> None: + """Test step to validate keys, values and data types from cdns endpoint response. + :param to_session: Fixture to get Traffic ops session + :param get_cdn_data: Fixture to get cdn data from a prereq file + :param cdn_prereq: Fixture to get sample cdn data and actual cdn response + """ + # validate CDN keys from cdns get response + logger.info("Accessing Cdn endpoint through Traffic ops session.") + cdn_name = cdn_prereq[0]["name"] + cdn_get_response = to_session.get_cdns( + query_params={"name": cdn_name}) + try: + cdn_data = cdn_get_response[0] + cdn_keys = list(cdn_data[0].keys()) + logger.info( + "CDN Keys from cdns endpoint response %s", cdn_keys) + # validate cdn values from prereq data in cdns get response. + prereq_values = [cdn_prereq[0]["name"], cdn_prereq[0] + ["domainName"], cdn_prereq[0]["dnssecEnabled"]] + get_values = [cdn_data[0]["name"], cdn_data[0] + ["domainName"], cdn_data[0]["dnssecEnabled"]] + # validate data types for values from cdn get json response. + for (prereq_value, get_value) in zip(prereq_values, get_values): + assert isinstance(prereq_value, type(get_value)) + assert cdn_keys.sort() == list(get_cdn_data.keys()).sort() + assert get_values == prereq_values + except IndexError: + logger.error("No CDN data from cdns get request") + pytest.fail("Response from get request is empty, Failing test_get_cdn") + finally: + # Delete CDN after test execution to avoid redundancy. + try: + cdn_response = cdn_prereq[1] + cdn_id = cdn_response["id"] + to_session.delete_cdn_by_id(cdn_id=cdn_id) + except IndexError: + logger.error("CDN wasn't created") Review Comment: Yes, Marked the test as fail. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
