shamrickus opened a new pull request, #7497: URL: https://github.com/apache/trafficcontrol/pull/7497
<!-- Thank you for contributing! Please be sure to read our contribution guidelines: https://github.com/apache/trafficcontrol/blob/master/CONTRIBUTING.md If this closes or relates to an existing issue, please reference it using one of the following: Closes: #ISSUE Related: #ISSUE If this PR fixes a security vulnerability, DO NOT submit! Instead, contact the Apache Traffic Control Security Team at [email protected] and follow the guidelines at https://apache.org/security regarding vulnerability disclosure. --> This PR bridges the gap of parity between TPv2 and v1 in terms of Servers Detail/Table doing a variety of things and in the process fixing #7485, #7484. Specifically the following was changed/added: * E2E tests * Extracting out the the E2E test data creation into it's own class and improving error messages so the user is aware of what request failed. * The test data creation is now run twice to ensure they are idempotent. * Upgrade the API version used by test data creation to 4.1 * The common table PO has been updated to add various methods that can be used to filter the table/select a row. The Servers Detail test have been updated to use these to navigate to a detail instead of using hardcoded urls. * Default window size of non-headless runs has been set. * Updated to required node version to be what Angular 15 needs. * Added CSS vars for toolbar/sidebar sizes. * Servers Detail * Implemented update (previous was just a button that wasn't hooked up) & delete. * Implemented layered profiles * Implement New server. * Converted from UI design from a TP clone to something that looks similar but uses material components. * Added links to view details of fields such as CDN, Cache Group, etc. * Added help text in the form of suffix icon tooltips (MGMT fields) * Implement Queue/Clear Server Updates * Generic Table * Fixed a bug where the clicking the select label in the dropdown menus (such as column visibility) was not working and only worked if you clicked the select element, but not the label. * Added the ability to add "More" buttons. Moved `Resize` and `Export Grid` to the menu. * Added the ability to bind to the double click event on a grid row. * Fixed a bug on dropdown menus where the arrow would not rotate when opening a menu (column visibility and now more) * Servers Table * Add Create Server FAB * Added Queue/Dequeue buttons to the more menu (by cdn) * Added double click row to goto server details. <!-- **^ Add meaningful description above** --><hr/> ## Which Traffic Control components are affected by this PR? <!-- Please delete all components from this list that are NOT affected by this PR. Feel free to add the name of a tool or script that is affected but not on the list. --> - Documentation - Traffic Portal v2 ## What is the best way to verify this PR? Ensure the changes work (listed above). Verify that the content works and looks good at various resolutions. Compare to TPv1 page to check parity. <!-- Please include here ALL the steps necessary to test your PR. If your PR has tests (and most should), provide the steps needed to run the tests. If not, please provide step-by-step instructions to test the PR manually and explain why your PR does not need tests. --> ## If this is a bugfix, which Traffic Control versions contained the bug? <!-- Delete this section if the PR is not a bugfix, or if the bug is only in the master branch. Examples: - 5.1.2 - 5.1.3 (RC1) --> - master ## PR submission checklist - [x] This PR has tests <!-- If not, please delete this text and explain why this PR does not need tests. --> - [ ] This PR has documentation <!-- If not, please delete this text and explain why this PR does not need documentation. --> - [ ] This PR has a CHANGELOG.md entry <!-- A fix for a bug from an ATC release, an improvement, or a new feature should have a changelog entry. --> - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://apache.org/security) for details) <!-- Licensed to the Apache Software Foundation (ASF) under one or more contributor license agreements. See the NOTICE file distributed with this work for additional information regarding copyright ownership. The ASF licenses this file to you under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
