shamrickus commented on code in PR #7497:
URL: https://github.com/apache/trafficcontrol/pull/7497#discussion_r1188798379
##########
experimental/traffic-portal/src/app/core/misc/isogeneration-form/isogeneration-form.component.html:
##########
@@ -79,31 +79,6 @@
</mat-form-field>
</fieldset>
</mat-card>
- <mat-card appearance="outlined">
- <fieldset>
- <legend mat-card-title>Management
Network Interface Details</legend>
- <mat-form-field>
- <mat-label>Management Interface
Device Name</mat-label>
- <input matInput type="text"
formControlName="mgmtInterface" placeholder="eth0"/>
- <mat-hint>This should be the
name of the network device relative to <code>/dev/</code>.</mat-hint>
- </mat-form-field>
- <mat-form-field>
- <mat-label>Management IPv4
Address</mat-label>
- <input matInput type="text"
formControlName="mgmtIpAddress"/>
- <mat-error>Invalid IPv4
address</mat-error>
- </mat-form-field>
- <mat-form-field>
- <mat-label>Management Gateway
IPv4 Address</mat-label>
- <input matInput type="text"
formControlName="mgmtIpGateway"/>
- <mat-error>Invalid IPv4
address</mat-error>
- </mat-form-field>
- <mat-form-field>
- <mat-label>Management IPv4
Netmask</mat-label>
- <input matInput type="text"
formControlName="mgmtIpNetmask"/>
- <mat-error>Invalid IPv4
Netmask</mat-error>
- </mat-form-field>
- </fieldset>
- </mat-card>
Review Comment:
It appears you deployed the types incorrectly. I see the fields on the repo,
but the v4.0.9 release _definitely_ does not have the mgmt fields.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
