ocket8888 commented on code in PR #7532:
URL: https://github.com/apache/trafficcontrol/pull/7532#discussion_r1205773929
##########
experimental/traffic-portal/src/app/shared/file-utils.service.ts:
##########
@@ -153,4 +153,21 @@ export class FileUtilsService {
this.window.open(url, "_blank");
URL.revokeObjectURL(url);
}
+
+ /**
+ * Exports File
+ *
+ * @param json object to be exported
+ * @param fileName name for the download file
+ * @param fileExtension extenstion of export file
+ */
+ public exportFile(json: object, fileName: string, fileExtension:
string): void {
Review Comment:
well, yes, it opens the attachment link in a new browsing context, which
doesn't require messing with the DOM of the current browsing context.
Altogether a better solution, imo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
