ocket8888 commented on code in PR #7532: URL: https://github.com/apache/trafficcontrol/pull/7532#discussion_r1205782370
########## experimental/traffic-portal/src/app/api/export-attachment.service.ts: ########## @@ -0,0 +1,50 @@ +/* +* Licensed under the Apache License, Version 2.0 (the "License"); +* you may not use this file except in compliance with the License. +* You may obtain a copy of the License at +* +* http://www.apache.org/licenses/LICENSE-2.0 +* +* Unless required by applicable law or agreed to in writing, software +* distributed under the License is distributed on an "AS IS" BASIS, +* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +* See the License for the specific language governing permissions and +* limitations under the License. +*/ + +import { HttpClient } from "@angular/common/http"; +import { Injectable } from "@angular/core"; +import { ProfileExport, ResponseProfile } from "trafficops-types"; + +import { environment } from "src/environments/environment"; + +/** + * Defines & handles api endpoints related to export attachments/json/text + * Here we are not using the base-api-service to tap the response. + */ +@Injectable() +export class ExportAttachmentService { Review Comment: Just because the response format differs doesn't mean you can't or shouldn't extend the API base class. Look at the `MiscAPIsService`'s `generateISO` method. It returns a raw octet stream from TO, but still extends the base class - partially because other methods make use of the base class's methods (like the Profile Service does), and partially because we shouldn't specify the API version in two different places. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
