shamrickus opened a new pull request, #7555: URL: https://github.com/apache/trafficcontrol/pull/7555
<!-- Thank you for contributing! Please be sure to read our contribution guidelines: https://github.com/apache/trafficcontrol/blob/master/CONTRIBUTING.md If this closes or relates to an existing issue, please reference it using one of the following: Closes: #ISSUE Related: #ISSUE If this PR fixes a security vulnerability, DO NOT submit! Instead, contact the Apache Traffic Control Security Team at [email protected] and follow the guidelines at https://apache.org/security regarding vulnerability disclosure. --> This PR adds the ability to inspect a user provided cert chain or the one from a specific DS. This requires the use of a new library `node-forge`. This library is relatively large (~200Kb compressed) and as such the functionality is relegated to it's own module. <!-- **^ Add meaningful description above** --><hr/> ## Which Traffic Control components are affected by this PR? <!-- Please delete all components from this list that are NOT affected by this PR. Feel free to add the name of a tool or script that is affected but not on the list. --> - Traffic Portal v2 ## What is the best way to verify this PR? Ensure the SSL chunk is _only_ loaded when navigating to one of the two endpoints, `core/certs/ssl` and `core/certs/ssl/ds/:xmlId`. The generic endpoint has a sidebar entry under `Other` and should work. For DS cert (which needs to be navigated to manually), there should be two tabs. One displaying the information that TO provides, and the other displaying the processed cert info. The generic cert also has two tabs, the processed tab like with DS cert, and an input tab where the user can input the cert. The only validation that should occur on this tab is ensuring the cert field is not empty. The processed cert screen should show the chain in root -> client cert. It should also display the detected order (if possible). In case of a cert that doesn't match or a cert doesn't parse it should properly update the order to "Unknown" and that specific certs name to "Error". <!-- Please include here ALL the steps necessary to test your PR. If your PR has tests (and most should), provide the steps needed to run the tests. If not, please provide step-by-step instructions to test the PR manually and explain why your PR does not need tests. --> <!-- Delete this section if the PR is not a bugfix, or if the bug is only in the master branch. Examples: - 5.1.2 - 5.1.3 (RC1) --> ## PR submission checklist - [x] This PR has tests <!-- If not, please delete this text and explain why this PR does not need tests. --> - [ ] This PR has documentation <!-- If not, please delete this text and explain why this PR does not need documentation. --> - [ ] This PR has a CHANGELOG.md entry <!-- A fix for a bug from an ATC release, an improvement, or a new feature should have a changelog entry. --> - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://apache.org/security) for details) <!-- Licensed to the Apache Software Foundation (ASF) under one or more contributor license agreements. See the NOTICE file distributed with this work for additional information regarding copyright ownership. The ASF licenses this file to you under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
