rimashah25 commented on code in PR #7555:
URL: https://github.com/apache/trafficcontrol/pull/7555#discussion_r1246080185
##########
experimental/traffic-portal/src/app/api/testing/delivery-service.service.ts:
##########
@@ -16,7 +16,7 @@ import type {
Capacity,
Health,
RequestDeliveryService,
- ResponseDeliveryService,
+ ResponseDeliveryService, ResponseDeliveryServiceSSLKey,
Review Comment:
nit: new line
##########
experimental/traffic-portal/src/app/core/certs/cert-viewer/cert-viewer.component.html:
##########
@@ -0,0 +1,77 @@
+<!--
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+-->
+
+<mat-card appearance="outlined" class="page-content">
+ <tp-loading *ngIf="dsCert === undefined"></tp-loading>
+ <mat-card-content *ngIf="dsCert !== undefined">
+ <mat-tab-group #matTab>
+ <mat-tab label="Input Certificate" *ngIf="!dsCert">
+ <form ngNativeValidate
(submit)="process(true)" class="tab-content">
+ <mat-form-field>
+ <mat-label>Certificate
Chain</mat-label>
+ <textarea matInput
name="custom" [(ngModel)]="inputCert" cdkAutosizeMaxRows="15"
cdkTextareaAutosize required></textarea>
+ </mat-form-field>
+ <button mat-raised-button
type="submit">Submit</button>
+ </form>
+ </mat-tab>
+ <mat-tab label="Certificate Details"
[disabled]="certChain.length === 0">
+ <div class="tab-content">
+ <mat-form-field>
+ <mat-label>Detected
Order</mat-label>
+ <input matInput readonly
name="order" [(ngModel)]="certOrder"/>
Review Comment:
Do we not need a type label for a given input?
##########
experimental/traffic-portal/src/app/core/certs/cert-viewer/cert-viewer.component.html:
##########
@@ -0,0 +1,77 @@
+<!--
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+-->
+
+<mat-card appearance="outlined" class="page-content">
+ <tp-loading *ngIf="dsCert === undefined"></tp-loading>
+ <mat-card-content *ngIf="dsCert !== undefined">
+ <mat-tab-group #matTab>
+ <mat-tab label="Input Certificate" *ngIf="!dsCert">
+ <form ngNativeValidate
(submit)="process(true)" class="tab-content">
+ <mat-form-field>
+ <mat-label>Certificate
Chain</mat-label>
+ <textarea matInput
name="custom" [(ngModel)]="inputCert" cdkAutosizeMaxRows="15"
cdkTextareaAutosize required></textarea>
+ </mat-form-field>
+ <button mat-raised-button
type="submit">Submit</button>
+ </form>
+ </mat-tab>
+ <mat-tab label="Certificate Details"
[disabled]="certChain.length === 0">
+ <div class="tab-content">
+ <mat-form-field>
+ <mat-label>Detected
Order</mat-label>
+ <input matInput readonly
name="order" [(ngModel)]="certOrder"/>
+ </mat-form-field>
+ <mat-accordion>
+ <mat-expansion-panel
*ngFor="let c of certChain; let i = index;">
+
<mat-expansion-panel-header>{{c.type}}</mat-expansion-panel-header>
+ <tp-cert-detail
*ngIf="!c.parseError" [cert]="c"></tp-cert-detail>
+ <div
*ngIf="c.parseError">Unable to parse this certificate!</div>
+ </mat-expansion-panel>
+ </mat-accordion>
+ </div>
+ </mat-tab>
+ <mat-tab label="TO Cert Info" *ngIf="dsCert">
+ <div class="tab-content">
+ <mat-form-field>
+ <mat-label>Version</mat-label>
+ <input type="text" matInput
name="version" [(ngModel)]="cert.version" />
+ </mat-form-field>
+ <mat-form-field>
+ <mat-label>Common
Name</mat-label>
+ <input type="text" matInput
name="commonName" [(ngModel)]="cert.hostname" />
+ </mat-form-field>
+ <mat-form-field>
+
<mat-label>Expiration</mat-label>
+ <input type="text" matInput
name="expiration" [(ngModel)]="cert.expiration" />
+ </mat-form-field>
+ <mat-form-field>
+ <mat-label>SANs</mat-label>
+ <input type="text" matInput
name="sans" [(ngModel)]="cert.sans" />
+ </mat-form-field>
+ <mat-form-field>
+ <mat-label>Private
Key</mat-label>
+ <textarea matInput
name="privateKey" [(ngModel)]="cert.certificate.key" cdkAutosizeMaxRows="15"
cdkTextareaAutosize></textarea>
Review Comment:
Need to blur the value
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
