rimashah25 commented on code in PR #7549:
URL: https://github.com/apache/trafficcontrol/pull/7549#discussion_r1220837137
##########
docs/source/api/v5/cdns.rst:
##########
@@ -89,15 +89,15 @@ Response Structure
"dnssecEnabled": false,
"domainName": "-",
"id": 1,
- "lastUpdated": "2018-11-14 18:21:06+00",
+ "lastUpdated": "2018-11-14T18:21.516553Z",
Review Comment:
RFC3339 format is as follows: 2023-06-06T22:44:53.557642-06:00. Why is it
different in this file?
##########
traffic_ops/traffic_ops_golang/cdn/cdns.go:
##########
Review Comment:
Aren't we trying to get rid of cruder? If yes, then why add cruder
functionality in V5 instead of adding Read/Update/Create/Delete functions?
##########
traffic_ops/traffic_ops_golang/routing/routes.go:
##########
@@ -367,10 +367,10 @@ func Routes(d ServerData) ([]Route, http.Handler, error) {
{Version: api.Version{Major: 5, Minor: 0}, Method:
http.MethodDelete, Path: `cdn_notifications/?$`, Handler:
cdnnotification.Delete, RequiredPrivLevel: auth.PrivLevelOperations,
RequiredPermissions: []string{"CDN:UPDATE"}, Authenticated: Authenticated,
Middlewares: nil, ID: 27224118511},
//CDN generic handlers:
Review Comment:
Wouldn't it make more sense to get rid of cruder functionality?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
