jagan-parthiban commented on code in PR #7549:
URL: https://github.com/apache/trafficcontrol/pull/7549#discussion_r1279027359
##########
traffic_ops/traffic_ops_golang/cdn/cdns.go:
##########
@@ -20,71 +20,324 @@ package cdn
*/
import (
+ "database/sql"
+ "encoding/json"
+ "errors"
"fmt"
"net/http"
"strconv"
"strings"
"time"
+ "github.com/apache/trafficcontrol/lib/go-log"
"github.com/apache/trafficcontrol/lib/go-tc"
"github.com/apache/trafficcontrol/lib/go-tc/tovalidate"
"github.com/apache/trafficcontrol/lib/go-util"
"github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/api"
"github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/dbhelpers"
+
"github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/util/ims"
"github.com/asaskevich/govalidator"
validation "github.com/go-ozzo/ozzo-validation"
)
-// we need a type alias to define functions on
+// TOCDN is the struct needed for the CRUDer
type TOCDN struct {
api.APIInfoImpl `json:"-"`
tc.CDNNullable
}
-func (v *TOCDN) GetLastUpdated() (*time.Time, bool, error) {
- return api.GetLastUpdated(v.APIInfo().Tx, *v.ID, "cdn")
+func Read(w http.ResponseWriter, r *http.Request) {
+ var runSecond bool
+ var maxTime time.Time
+ inf, userErr, sysErr, errCode := api.NewInfo(r, nil, nil)
+ tx := inf.Tx
+ if userErr != nil || sysErr != nil {
+ api.HandleErr(w, r, tx.Tx, errCode, userErr, sysErr)
+ return
+ }
+ defer inf.Close()
+
+ // Query Parameters to Database Query column mappings
+ queryParamsToQueryCols := map[string]dbhelpers.WhereColumnInfo{
+ "domainName": dbhelpers.WhereColumnInfo{Column:
"domain_name"},
+ "dnssecEnabled": dbhelpers.WhereColumnInfo{Column:
"dnssec_enabled"},
+ "id": dbhelpers.WhereColumnInfo{Column: "id",
Checker: api.IsInt},
+ "name": dbhelpers.WhereColumnInfo{Column: "name"},
+ "ttlOverride": dbhelpers.WhereColumnInfo{Column:
"ttl_override", Checker: api.IsInt},
+ }
+
+ if _, ok := inf.Params["orderby"]; !ok {
+ inf.Params["orderby"] = "name"
+ }
+ where, orderBy, pagination, queryValues, errs :=
dbhelpers.BuildWhereAndOrderByAndPagination(inf.Params, queryParamsToQueryCols)
+ if len(errs) > 0 {
+ api.HandleErr(w, r, tx.Tx, http.StatusBadRequest,
util.JoinErrs(errs), nil)
+ return
+ }
+
+ if inf.Config.UseIMS {
+ runSecond, maxTime = ims.TryIfModifiedSinceQuery(tx, r.Header,
queryValues, SelectMaxLastUpdatedQuery(where))
+ if !runSecond {
+ log.Debugln("IMS HIT")
+ api.AddLastModifiedHdr(w, maxTime)
+ w.WriteHeader(http.StatusNotModified)
+ return
+ }
+ log.Debugln("IMS MISS")
+ } else {
+ log.Debugln("Non IMS request")
+ }
+
+ query := selectQuery(inf.Version) + where + orderBy + pagination
+ rows, err := tx.NamedQuery(query, queryValues)
+ if err != nil {
+ api.HandleErr(w, r, tx.Tx, http.StatusNotFound, nil,
fmt.Errorf("cdn get: error getting cdn(s): %w", err))
+ return
+ }
+ defer log.Close(rows, "unable to close DB connection")
+
+ cdn := tc.CDNV5{}
+ cdns := []tc.CDNV5{}
+ for rows.Next() {
+ if err = rows.Scan(&cdn.DNSSECEnabled, &cdn.DomainName,
&cdn.ID, &cdn.LastUpdated, &cdn.TTLOverride, &cdn.Name); err != nil {
+ api.HandleErr(w, r, tx.Tx,
http.StatusInternalServerError, nil, fmt.Errorf("error getting cdn(s): %w",
err))
+ return
+ }
+ cdns = append(cdns, cdn)
+ }
+
+ api.WriteResp(w, r, cdns)
+ return
+}
+
+func Create(w http.ResponseWriter, r *http.Request) {
+ cdn := tc.CDNV5{}
+
+ inf, userErr, sysErr, errCode := api.NewInfo(r, nil, nil)
+ if userErr != nil || sysErr != nil {
+ api.HandleErr(w, r, inf.Tx.Tx, errCode, userErr, sysErr)
+ return
+ }
+ defer inf.Close()
+ tx := inf.Tx.Tx
+
+ cdn, err := validateRequest(r, inf.Version)
+ if err != nil {
+ api.HandleErr(w, r, tx, http.StatusBadRequest, err, nil)
+ return
+ }
+
+ var exists bool
+ if err = tx.QueryRow("SELECT EXISTS(SELECT id from cdn where name =
$1)", cdn.Name).Scan(&exists); err != nil {
+ api.HandleErr(w, r, tx, http.StatusInternalServerError, nil,
fmt.Errorf("error: %w, when checking if cdn with name %s exists", err,
cdn.Name))
+ return
+ }
+ if exists {
+ api.HandleErr(w, r, tx, http.StatusBadRequest, fmt.Errorf("cdn
name '%s' already exists.", cdn.Name), nil)
+ return
+ }
+
+ cdn.DomainName = strings.ToLower(cdn.DomainName)
+
+ rows, err := inf.Tx.NamedQuery(insertQuery(inf.Version), cdn)
+ if err != nil {
+ if errors.Is(err, sql.ErrNoRows) {
+ api.HandleErr(w, r, tx, http.StatusInternalServerError,
fmt.Errorf("error: %w in creating cdn with name: %s", err, cdn.Name), nil)
+ return
+ }
+ usrErr, sysErr, code := api.ParseDBError(err)
+ api.HandleErr(w, r, tx, code, usrErr, sysErr)
+ return
+ }
+ if rows.Next() {
+ if err = rows.Scan(&cdn.ID, &cdn.LastUpdated); err != nil {
+ usrErr, sysErr, code := api.ParseDBError(err)
+ api.HandleErr(w, r, tx, code, usrErr, sysErr)
+ return
+ }
+ }
+
+ alerts := tc.CreateAlerts(tc.SuccessLevel, "cdn was created.")
+ w.Header().Set("Location", fmt.Sprintf("/api/%d.%d/cdns?name=%s",
inf.Version.Major, inf.Version.Minor, cdn.Name))
+ api.WriteAlertsObj(w, r, http.StatusCreated, alerts, cdn)
+ return
+}
+
+func Update(w http.ResponseWriter, r *http.Request) {
Review Comment:
V5 Update Function not returning CDN ID like V4.
**V5 Response**
```{
"alerts": [
{
"text": "cdn was updated.",
"level": "success"
}
],
"response": {
"dnssecEnabled": false,
"domainName": "test1new",
"id": 0,
"lastUpdated": "2023-07-31T12:20:17.617043+05:30",
"name": "a-test11",
"ttlOverride": 60
}
}
```
**V4 Response**
```{
"alerts": [
{
"text": "cdn was updated.",
"level": "success"
}
],
"response": {
"dnssecEnabled": false,
"domainName": "test1new",
"id": 1779,
"lastUpdated": "2023-07-31 12:20:41+05",
"name": "a-test111",
"ttlOverride": 60
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
